Avoid unnecessary conversions between model.Metric and labels.Labels #6710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaochao Dong (@damnever) <[email protected]>
yeya24
approved these changes
Apr 20, 2025
Signed-off-by: Xiaochao Dong (@damnever) <[email protected]>
|
@yeya24 I haven't conducted a benchmark |
|
Not a serious benchmark, but the latency decreases by ~17% when I query 700k series manually.. I also slightly modified this benchmark, which has shown some improvements. - assert.Contains(b, []int{numIngesters, numIngesters - 1}, countMockIngestersCalls(ingesters, "MetricsForLabelMatchers"))
- assert.Equal(b, numSeriesPerRequest, len(metrics))
+ // assert.Contains(b, []int{numIngesters, numIngesters - 1}, countMockIngestersCalls(ingesters, "MetricsForLabelMatchers"))
+ // assert.Equal(b, numSeriesPerRequest, len(metrics))
+ _ = ingesters
+ seriesSet := series.MetricsToSeriesSet(ctx, false, metrics)
+ for seriesSet.Next() {
+ _ = seriesSet.At()
+ } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Remove complex conversions when selecting only series:
LabelAdapters->model.Metric(map)->labels.Labels.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]